feat(store): namespace settings by scope and domain - #2456
Open
sofiazcoaga wants to merge 2 commits into
Open
Conversation
sofiazcoaga
force-pushed
the
add-domain-to-settings
branch
from
August 27, 2026 13:58
b29cd3c to
08b7848
Compare
juan518munoz
added
the
no migration check
juan518munoz
approved these changes
Aug 31, 2026
juan518munoz
left a comment
juan518munoz
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Don't forget to add a changelog entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The settings table had one flat keyspace shared by the client and its users, so
client.set_setting()let a user overwrite the client's own state with no error. Also,list_setting_keys()returned the client's internal keys to the caller.Changes
This PR adds a
scopeand adomainto thesettingstable, with(scope, domain, name)as the primary key.SettingDomain::new()is public and always builds a user domain. The client's own domains cannot be built from outside the crate.Existing stores are not compatible and must be recreated.
Closes #1352.